Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for embedded-hal 1.0 #1

Merged
merged 7 commits into from
Feb 24, 2024
Merged

Update for embedded-hal 1.0 #1

merged 7 commits into from
Feb 24, 2024
+86 −67

Conversation

madmo
Copy link
Contributor

@madmo madmo commented Feb 19, 2024

Updated all dependencies to work with embedded-hal version 1.0

eldruin
eldruin reviewed Feb 23, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!
Could you also:

  • Add an entry to the changelog about this?
  • Fix the formatting?
  • Update the MSRV to Rust 1.62.0?

@madmo
Copy link
Contributor Author

madmo commented Feb 23, 2024

Nice, thanks! Could you also:

  • Add an entry to the changelog about this?
  • Fix the formatting?
  • Update the MSRV to Rust 1.62.0?

Sure, pushed the new changes. Thanks for the feedback 👍

@eldruin
Copy link
Owner

eldruin commented Feb 23, 2024

Thanks! So that we get the CI to pass, could you add an underscore in these unused arguments in the test and also update the CI clippy version to 1.62.0?

@madmo
Copy link
Contributor Author

madmo commented Feb 23, 2024

Ok, now I fixed all warnings, all green: https://github.com/madmo/opt300x-rs/actions/runs/8021089068

Replaced cargo-tarpulin with cargo-llvm-cov, because the tarpulin action seems to be broken/abdoned.

eldruin
eldruin reviewed Feb 24, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, looks good to me!
Do you have any reason to set the MSRV in CI to 1.63.0 instead of 1.62.0 that I should be aware of? or was it only a typo?

Cargo.toml Outdated Show resolved Hide resolved
@madmo
Copy link
Contributor Author

madmo commented Feb 24, 2024

Great, looks good to me! Do you have any reason to set the MSRV in CI to 1.63.0 instead of 1.62.0 that I should be aware of? or was it only a typo?

The tests were not compiling for me under 1.62.0 because of embedded-hal-mock v0.10.0 which requires 1.63.0.
I thought 1.62.0 was a typo.

eldruin
eldruin reviewed Feb 24, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I see. Normally in the CI I run the tests only on stable due to these kind of issues with dev-dependencies and only build this crate with the selected MSRV.

.github/workflows/build.yml Outdated Show resolved Hide resolved
eldruin
eldruin approved these changes Feb 24, 2024
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you for your work!

@eldruin eldruin merged commit 64ce6d2 into eldruin:master Feb 24, 2024
24 checks passed
@eldruin
Copy link
Owner

eldruin commented Jul 31, 2024

For the record, I published this in version 1.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madmo @eldruin